OAK-12057 - Select same plan with or without LIMIT option #2684
+72
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmueller
approved these changes
Jan 16, 2026
Member
thomasmueller
left a comment
thomasmueller
left a comment
There was a problem hiding this comment.
Cosmetic: I would remove unnecessary lines, but it's fine if you don't agree.
I just wanted to share my opinion.
| parsedQuery.setTraversalEnabled(false); | ||
| parsedQuery.prepare(); | ||
|
|
||
| // Then |
| */ | ||
| @Test | ||
| public void testPlanningWithLimit() throws ParseException { | ||
| // Given |
Member
There was a problem hiding this comment.
Suggested change
| // Given |
Author
I kind of like them as I find they add readbility in clarifying: what are the hypothesis, what is being tested and what are the expectations. Without them, this effort needs to be done every time the test is opened, especially months or years later. This said, I understand this may mot align with the current state of the code base :) |
fabriziofortino
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.