Added support for dynamic SSL certificate reload for controllers#22688
Open
aschmidt402 wants to merge 1 commit into
Open
Added support for dynamic SSL certificate reload for controllers#22688aschmidt402 wants to merge 1 commit into
aschmidt402 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented dynamic reloading of SSL certificates for the KRaft controller listener via kafka-configs --alter --entity-type controllers. This is done via:
Testing
Unit Tests
ConfigurationControlManagerTest.testIncrementalAlterControllerConfigs: validates controller-specific validation (accepts SSL keys with listener prefix, rejects non-SSL keys, rejects non-numeric resource names)
Integration Tests
a. Boots isolated KRaft controller with SSL on CONTROLLER listener using keystore A
b. Reads the baseline cert serial via SSLSocket handshake
c. Issues IncrementalAlterConfigs against ConfigResource.Type.CONTROLLER pointing at keystore B
d. Polls new TLS connections until the presented cert serial matches keystore B
e. Asserts rotation occurred without restart