feat(i18n): add Traditional Chinese locale #3853
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { ensureSidebarExpanded, expect, test } from './fixtures'; | ||
|
|
||
| test('switches General Settings from Simplified to Traditional Chinese', async ({ | ||
| window: page, | ||
| }) => { | ||
| await ensureSidebarExpanded(page); | ||
| await page.getByRole('button', { name: '设置', exact: true }).click(); | ||
|
Contributor
There was a problem hiding this comment. [P2] Expand the sidebar before trying to open Settings. The shared |
||
| await expect(page.getByRole('main', { name: '设置内容' })).toBeVisible(); | ||
| await page.getByRole('button', { name: '通用', exact: true }).click(); | ||
| await expect(page.getByText('界面语言', { exact: true }).first()).toBeVisible(); | ||
| await page.keyboard.press('Escape'); | ||
|
|
||
| await page.evaluate(async () => { | ||
| await window.maka.settings.update({ personalization: { uiLocale: 'zh-TW' } }); | ||
| }); | ||
| await page.reload(); | ||
| await page.waitForSelector('.maka-composer-editor'); | ||
| await ensureSidebarExpanded(page); | ||
| await page.getByRole('button', { name: '設定', exact: true }).click(); | ||
| await expect(page.getByRole('main', { name: '設定內容' })).toBeVisible(); | ||
| await page.getByRole('button', { name: '通用', exact: true }).click(); | ||
| await expect(page.getByText('介面語言', { exact: true }).first()).toBeVisible(); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import assert from 'node:assert/strict'; | ||
| import { test } from 'node:test'; | ||
| import { getAgentGraphPanelCopy } from '../../renderer/agent-graph-panel.js'; | ||
|
|
||
| test('Traditional Chinese Agent Graph copy does not use Simplified fallbacks', () => { | ||
| const copy = getAgentGraphPanelCopy('zh-TW'); | ||
| assert.equal(copy.loading, '正在讀取 Graph 狀態…'); | ||
| assert.equal(copy.openSession, '開啟子任務'); | ||
| assert.equal(copy.currentEpoch, '目前'); | ||
| assert.equal(copy.status('active'), '執行中'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tightening this fixture contract to canonical locales. Two call sites were missed:
partialHistoryWindow(line 614) andrailRenderWindow(line 587) still passlocale: "zh". The main fixture parser now accepts onlyzh-CN,zh-TW, oren, so those values become null (and they also contradict this narrowed TypeScript type). In particular, partial-history skips settings seeding but still asserts Simplified-Chinese notice text, so on an English CI host the existing spec should render English and fail. I suggest changing both remaining literals tozh-CNand adding/retaining a focused canonical-fixture assertion. Please push back if another layer intentionally maps these two legacy values.