Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,11 @@ function peerReachability() {

test('treats an unavailable collaboration authority as an empty background inbox', async () => {
const handlers = new Map<string, IpcHandler>();
let queryCalls = 0;
registerRuntimeHostCollaborationIpc(
{
async queryCollaborationTurnRequests() {
queryCalls += 1;
throw new RuntimeHostOperationError(
'collaboration.turn-request.query',
'operation_unavailable',
Expand All @@ -191,6 +193,11 @@ test('treats an unavailable collaboration authority as an empty background inbox
canRequestTurns: false,
requests: [],
});
assert.deepEqual(await query({} as Parameters<IpcHandler>[0]), {
canRequestTurns: false,
requests: [],
});
assert.equal(queryCalls, 1);
await assert.rejects(
query({} as Parameters<IpcHandler>[0], 'session-1'),
RuntimeHostOperationError,
Expand Down
5 changes: 5 additions & 0 deletions apps/desktop/src/main/runtime-host-collaboration-ipc-main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export function registerRuntimeHostCollaborationIpc(
| DesktopCollaborationConnectionTarget
| Promise<DesktopCollaborationConnectionTarget>,
): void {
let backgroundInboxUnavailable = false;
ipcMain.handle(
'session-collaboration:prepare',
async (
Expand Down Expand Up @@ -97,10 +98,14 @@ export function registerRuntimeHostCollaborationIpc(
async (_event, sessionId: unknown) => {
const requestedSessionId =
sessionId === undefined ? undefined : requiredId(sessionId, 'Session');
if (requestedSessionId === undefined && backgroundInboxUnavailable) {
return { canRequestTurns: false, requests: [] };
}
try {
return await client.queryCollaborationTurnRequests(requestedSessionId);
} catch (error) {
if (requestedSessionId === undefined && isCollaborationInboxUnavailable(error)) {
backgroundInboxUnavailable = true;
return { canRequestTurns: false, requests: [] };
}
throw error;
Expand Down