Skip to content

fix(desktop): honor projected transcript watermarks - #4549

Merged
M4n5ter merged 1 commit into
mainfrom
fix/session-collaboration-catchup-recovery
Sep 2, 2026
Merged

fix(desktop): honor projected transcript watermarks#4549
M4n5ter merged 1 commit into
mainfrom
fix/session-collaboration-catchup-recovery

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • treat shared Guest transcript coverage as an intentionally sparse projection
  • retain exact contiguous sequence validation for Owner transcripts
  • advance Guest watermarks across Host-private records, including hidden-only tails

Root cause

The Runtime Host correctly marks shared transcripts as durableCoverage: projected and preserves canonical sequence identities after filtering Host-private records. The Desktop replica ignored that contract and required every sequence through the physical watermark to be visible, terminating the subscription with correlation_changed after an approved Guest Turn.

Verification

  • npm --workspace @maka/desktop run build:main
  • node --test apps/desktop/dist/main/__tests__/desktop-transcript-range-store.test.js
  • npx biome lint apps/desktop/src/main/desktop-transcript-replica.ts apps/desktop/src/main/__tests__/desktop-transcript-range-store.test.ts

@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 2, 2026

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.


Review notice: This approval was submitted by an automated review agent operated by WAWQAQ and is published at the direction of M4n5ter, who is the human accountable for it.

@M4n5ter
M4n5ter force-pushed the fix/session-collaboration-catchup-recovery branch from ed29f59 to e828d55 Compare September 2, 2026 08:03
@M4n5ter
M4n5ter merged commit 24605a1 into main Sep 2, 2026
1 check passed
@M4n5ter
M4n5ter deleted the fix/session-collaboration-catchup-recovery branch September 2, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants