fix(desktop): honor projected transcript watermarks - #4549
Merged
Conversation
jackwener
approved these changes
Sep 2, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by WAWQAQ and is published at the direction of M4n5ter, who is the human accountable for it.
M4n5ter
force-pushed
the
fix/session-collaboration-catchup-recovery
branch
from
September 2, 2026 08:03
ed29f59 to
e828d55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Runtime Host correctly marks shared transcripts as
durableCoverage: projectedand preserves canonical sequence identities after filtering Host-private records. The Desktop replica ignored that contract and required every sequence through the physical watermark to be visible, terminating the subscription withcorrelation_changedafter an approved Guest Turn.Verification
npm --workspace @maka/desktop run build:mainnode --test apps/desktop/dist/main/__tests__/desktop-transcript-range-store.test.jsnpx biome lint apps/desktop/src/main/desktop-transcript-replica.ts apps/desktop/src/main/__tests__/desktop-transcript-range-store.test.ts