fix(desktop): enable local remote access on Windows - #4728
Merged
Conversation
M4n5ter
force-pushed
the
fix/windows-local-remote-access
branch
5 times, most recently
from
September 4, 2026 07:06
1a58c08 to
724e71f
Compare
jackwener
approved these changes
Sep 4, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at exact head 9d7ccd8013d5867e3e7410a33c54e2bf7035247d at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts responsibility for subsequent handling.
Review notice: This approval was submitted by an automated review agent operated by jackwener and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
M4n5ter
force-pushed
the
fix/windows-local-remote-access
branch
from
September 4, 2026 08:49
6604c6a to
6737b5a
Compare
M4n5ter
force-pushed
the
fix/windows-local-remote-access
branch
from
September 4, 2026 08:53
6737b5a to
f9dfa09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
The installed lifecycle provider remains the source of truth; Desktop only checks the capability it actually needs.
Verification
npm exec -- biome checkfor all changed filesnpm run typecheck --workspace @maka/desktopnpm run typecheck --workspace maka-agentnpm run build --workspace maka-agent && npm run test:dist --workspace maka-agent(793 tests passed, 3 skipped)cargo clippy --locked --all-targets -- -D warningsandcargo test --lockedfornative/runtime-host-peercargo checkand Clippy fornative/runtime-host-windows-task-launcheractionlint .github/workflows/cli-package-validation.ymlAI use
Select exactly one:
Tool(s) and scope: Codex implemented, reviewed, and verified the change, including native Windows testing.
Checklist
Does this PR entail a change in behavior?
中文
摘要
已安装的生命周期 provider 仍是事实来源;Desktop 只检查真正需要的能力。
验证
npm exec -- biome checknpm run typecheck --workspace @maka/desktopnpm run typecheck --workspace maka-agentnpm run build --workspace maka-agent && npm run test:dist --workspace maka-agent(793 项通过,3 项跳过)native/runtime-host-peer运行cargo clippy --locked --all-targets -- -D warnings与cargo test --lockednative/runtime-host-windows-task-launcher运行 Windows target Cargo check 与 Clippyactionlint .github/workflows/cli-package-validation.ymlAI 使用
工具与范围:Codex 完成实现、审查和验证,包括原生 Windows 实测。
检查清单
此 PR 是否改变行为?