Skip to content

test(desktop): remove the layout-tier E2E specs that block main #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Sep 4, 2026
Merged

test(desktop): remove the layout-tier E2E specs that block main #4741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 3 additions & 25 deletions apps/desktop/e2e/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,6 @@ type E2eTestFixtures = {
railRenderWindow: Page;
promptRailWindow: Page;
partialHistoryWindow: Page;
promptRailMotionWindow: Page;
requestHeaderRowWindow: Page;
newTaskTargetWindow: Page;
directoryReferenceWindow: { page: Page; folder: string };
Expand Down Expand Up @@ -741,8 +740,9 @@ export const test = base.extend<E2eTestFixtures, E2eWorkerFixtures>({
await use({ app, page, viewport });
});
}, { scope: 'worker' }],
// A multi-prompt transcript for the prompt anchor rail. Shown, because every
// assertion in prompt-rail.spec.ts is geometry the compositor has to settle.
// A multi-prompt transcript. Shown, because the perf suite that measures it
// reads real frame pacing, and a throttled compositor paces nothing a user
// would see.
promptRailWindow: async ({ promptRailWorker }, use) => {
await setPromptRailWindowVisible(promptRailWorker, true);
try {
Expand All @@ -763,28 +763,6 @@ export const test = base.extend<E2eTestFixtures, E2eWorkerFixtures>({
showWindow: true,
}, use);
},
// The same transcript, scrolling the way the shipped app scrolls. Separate
// from `promptRailWindow` because it is only the jump that needs a scroll
// still in flight, and paying for one everywhere costs several seconds per
// window and settles less predictably.
promptRailMotionWindow: async ({}, use) => {
await withE2eWindow({
seed: false,
// The transcript and the fixture attributes arrive on two unordered
// async paths: `runDeferredStartupRefreshes` fires `refreshSessions()`
// and `applyE2eFixture()` side by side, and only the second one — after
// its `e2eFixture.getState()` IPC resolves — writes
// `data-maka-scroll-motion`. A turn can therefore paint while the
// document still says nothing about scroll motion. Requiring both in one
// selector is what makes "this window scrolls smoothly" true by the time
// a test body reads it.
readinessSelector: 'html[data-maka-scroll-motion="smooth"] [data-turn-id]',
e2eFixtureScenario: 'chat-prompt-rail',
locale: 'zh',
showWindow: true,
scrollMotion: 'smooth',
}, use);
},
// Settings → 模型, where `no-models` is the seeded openai-compatible relay —
// the connection type whose detail page owns the custom request headers
// editor. Shown, because what this window is for is a rendered box
Expand Down
Loading