Skip to content

fix(desktop): unblock the test job from its own tests #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
Sep 4, 2026
Merged

fix(desktop): unblock the test job from its own tests #4748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ef2448
fix(desktop): stop the Vite workspace test from outliving its server
Astro-Han Sep 4, 2026
2e6eb3c
fix(desktop): fail the renderer crypto test when its module is missing
Astro-Han Sep 4, 2026
69da9ae
test(desktop): remove the code-scroll spec that flakes on its selecti…
Astro-Han Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 0 additions & 133 deletions apps/desktop/e2e/code-scroll.spec.ts
View file
Open in desktop

This file was deleted.

13 changes: 12 additions & 1 deletion apps/desktop/scripts/vite-workspace-packages.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ test('renderer-facing Runtime Host protocol does not load Node crypto', async (t
configFile: false,
root,
logLevel: 'silent',
server: { host: '127.0.0.1', port: 0 },
// One request, one assertion — nothing here reacts to a file changing. A
// watcher would, and this root is the real repository: `close()` returns
// before its recursive scan finishes, and the unfinished fs requests keep
// the process alive until the workspace suite hits its own timeout.
server: { host: '127.0.0.1', port: 0, watch: null },
optimizeDeps: { noDiscovery: true, include: [] },
plugins: [workspacePackagesPlugin(repoRoot)],
});
Expand All @@ -102,5 +106,12 @@ test('renderer-facing Runtime Host protocol does not load Node crypto', async (t
const transformed = await response.text();

assert.equal(response.status, 200, transformed);
// A missing dist is served as the SPA fallback, and index.html trivially
// satisfies the assertion below. Say so instead of passing.
assert.doesNotMatch(
transformed,
/^<!doctype html>/iu,
'Vite served the SPA fallback; build @maka/runtime-host first',
);
assert.doesNotMatch(transformed, /vite-browser-external:node:crypto/u);
});