docs(architecture): audit Model access group against implementation - #4794
Open
ggbdpq wants to merge 1 commit into
Open
docs(architecture): audit Model access group against implementation#4794ggbdpq wants to merge 1 commit into
ggbdpq wants to merge 1 commit into
Conversation
Audit the two Model access documents from the apache#3522 documentation audit against the current implementation. openai-responses-incremental-transport.md: every named symbol resolves in the current source (session-fallback promptCacheKey with explicit value winning, turn-scoped continuation lane, endLane release, the five-minute cross-turn socket cooldown, the sdk.response.messages replay contrast). No drift; added the standard frontmatter with last_verified. model-metadata-firstscreen-optimization.md: the described optimization is implemented (onboarding:getSnapshot projection, conservative hasSecret:false, metadata-free onboarding hero copy, startup chain verified metadata-free), so the Problem section is now explicitly marked as the 2026-08-04 pre-optimization record in both languages. Fixed the cited renderer file name chat-model-selection.ts to the actual shell-chat-model-selection.ts. Added the standard frontmatter. The drift-grep recipes from the tracking issue return zero matches in both documents. Refs apache#3522 Generated-by: GLM-5.3-Flash (ZCode)
ggbdpq
force-pushed
the
docs/audit-model-access
branch
from
September 4, 2026 22:48
e97d75d to
039e93e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audits the Model access group (2 documents) from #3522 against the current implementation, one PR for the group as requested.
docs/architecture/openai-responses-incremental-transport.md— every named symbol resolves in the current source: the session-fallbackpromptCacheKey(maka:${sessionId}) where an explicit caller value wins (packages/runtime/src/openai-responses-continuation.ts:99), the turn-scoped continuation lane inModelAdapter(model-adapter.ts:145),endLaneand the five-minute cross-turn socket cooldown (openai-responses-websocket.ts:118,34), and thesdk.response.messagesreplay contrast (openai-responses-continuation.ts:37). No drift found, so the only change is the standard frontmatter withlast_verified.docs/model-metadata-firstscreen-optimization.md— the described optimization is implemented:onboarding:getSnapshotexists, the credential projection is conservativelyhasSecret: false(onboarding-service.ts:217), the onboarding hero copy is metadata-free, and the renderer startup chain (app-shell.tsx→use-shell-chat-model.ts→shell-chat-model-selection.ts) carries no runtime metadata import;PROVIDER_REGISTRYremains only under lazy settings paths. The Problem section is therefore now explicitly marked as the 2026-08-04 pre-optimization record, in both languages. One real drift fixed: the cited renderer filechat-model-selection.tsis actuallyshell-chat-model-selection.ts.The drift-grep recipes from the tracking issue (
run\.json,events\.jsonl,runtime-events\.jsonl,PermissionEngine,respondToPermission,agent-run-store\.test\.ts) return zero matches in both documents.Verification
git diff --staton this branchnpm run format:checknpm run check:asf-headers.gitkeepscratch file, not part of this PRpackages/runtime/srcapps/desktop/src/renderershell-chat-model-selection.tshas zero non-type importsLeft untouched on purpose: the point-in-time records (the 2026-08-04 chunk-size tables; the "34 passed" and "3,217 tests" runs in the OpenAI doc's Verification outcome) are historical results of earlier runs and stay as written.
AI use
Prepared with ZCode (GLM-5.3-Flash): the agent read both documents and the current source, traced each claim above to files and lines, and drafted the edits. The commit carries the
Generated-bytrailer.Checklist
Refs #3522in the commit messagetranslation_status: synced)last_verifiedset to the audit date (2026-09-04)