fix(desktop): warm and isolate Vite dev renderer - #4820
Closed
seekskyworld wants to merge 1 commit into
Closed
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com> Generated-by: OpenAI Codex
Contributor
Author
|
Closing as duplicate after verifying the existing implementation in #4782. I will not compete with that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4775
Dev launches now warm the Vite client entry and wait for its import graph to become idle before Electron starts. The main window clears the renderer session cache only for the Vite development entry, preventing stale immutable dependency generations from being combined with a fresh optimizer graph; packaged
file://launches keep their existing cache behavior.Verification
node --test apps/desktop/scripts/dev-renderer-warmup.test.mjs(2 passed)npm --workspace @maka/desktop run build:main(passed)node --test apps/desktop/dist/main/__tests__/main-renderer-loader.test.js(1 passed)npx tsc -p apps/desktop/tsconfig.main.json --noEmit(passed)npx biome linton all changed files (passed)npm --workspace @maka/desktop run build:workspace-depsreaches the existing@maka/uibaseline type errors on currentmain; it is not green in this checkout.AI use
Tool(s) and scope: OpenAI Codex authored the implementation and tests, then ran the focused checks listed above.
Checklist
Does this PR entail a change in behavior?