fix(ui): keep write geometry through a late scroll echo - #4834
Closed
orangeCatDeveloper wants to merge 1 commit into
Closed
fix(ui): keep write geometry through a late scroll echo#4834orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
The echo of the authority's own write refreshed the remembered scroll geometry. When that echo landed after content had grown but before the resize observer wrote the tail, the next offset move had no growth left to explain it and read as the reader scrolling away, so the pin was released and the tail stopped following. Generated-by: Claude Code Claude-Session: https://claude.ai/code/session_01RLZUUq5ri1bHzydQ7tw32b
orangeCatDeveloper
force-pushed
the
fix/transcript-scroll-echo-geometry
branch
from
September 5, 2026 07:26
4748966 to
5b733ab
Compare
Contributor
Author
|
Superseded by #4831, which reproduces the defect at the browser level and identifies the source of the offset move (content-visibility estimates above the viewport resolving while content grows below). Closing to avoid two conflicting fixes to the same file. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A pinned transcript could stop following its tail after content grew below the reader: the storybook smoke for
product-shell-official-appshell--tail-follows-growth-outside-turnsfailed on CI with the view left 509px short of a 600px growth (run 33945967155).createTranscriptScrollAuthoritytells its own write's scroll echo from the reader by offset, and when the echo arrived it also refreshed the remembered scroll geometry. If that echo landed after content had grown but before theResizeObserverwrote the tail, the growth was absorbed into the baseline, and the next offset move had no growth left to explain it. The band classifier then read a partial move as the reader scrolling away, released the pin, and the observer's write never came. The echo branch now leaves the geometry as the last write recorded it; the observer refreshes it on its own write, and a move the growth explains stays classified as content.The unit test replays the CI numbers (3523/860 scroller, +600 growth, +91 offset move → 509 from the tail) and fails without the change. The browser-level trigger of that +91 move was not reproduced locally (0/40 story runs at normal speed and under 8× CPU throttling), so this fixes the defect the numbers point at rather than a repro.
Verification
Also ran:
biome checkon the two files (clean); storybook smoke (290 stories / 316 renders passed). Not run: desktop E2E.AI use
Select exactly one:
Tool(s) and scope: Claude Code — diagnosis from the CI trace numbers, the fix, the test, and this description, under the contributor's direction; the commit carries a
Generated-by: Claude Codetrailer.Checklist
Does this PR entail a change in behavior?
https://claude.ai/code/session_01RLZUUq5ri1bHzydQ7tw32b