fix: restrict isNumeric() to ASCII digits to prevent NumberFormatExceptionRefactor digit validation logic in MavenArchiver#376
Merged
Conversation
Signed-off-by: Harsh Mehta <harshmehta010102@gmail.com>
Signed-off-by: Harsh Mehta <harshmehta010102@gmail.com>
elharo
approved these changes
Jul 2, 2026
|
|
||
| for (char c : str.toCharArray()) { | ||
| if (!Character.isDigit(c)) { | ||
| if (c < '0' || c > '9') { |
Contributor
There was a problem hiding this comment.
personally I prefer
c >= '0' && c <= '9'
but either way is fine
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #365
Problem
The
isNumeric()method currently usesCharacter.isDigit(), which returnstruefor many non-ASCII Unicode digits (such as Arabic-Indic٠١٢٣, Bengali০১২৩, and Devanagari०१२३).When
parseBuildOutputTimestamp()receives one of these values throughproject.build.outputTimestamporSOURCE_DATE_EPOCH,isNumeric()incorrectly treats it as a valid numeric string. The value is then passed toLong.parseLong()(around line 697), which only accepts ASCII digits (0–9) and throws aNumberFormatException.Since the method only catches
DateTimeParseException(around line 708), theNumberFormatExceptionpropagates uncaught, causing archive creation to fail with an unhelpful error message.Fix
Replace the use of
Character.isDigit()with an explicit ASCII digit check:Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.