[MSHARED-815] Pattern.compile() called on every invocation of handleSpecificationEntries#377
Open
elharo wants to merge 2 commits into
Open
[MSHARED-815] Pattern.compile() called on every invocation of handleSpecificationEntries#377elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
elharo
force-pushed
the
fix-370-pattern-compile-static
branch
from
137b860 to
3acd3c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #370
Pattern.compile()is called on every invocation ofhandleSpecificationEntries(), creating unnecessary GC pressure. This extracts the constant regex pattern to aprivate static final Patternfield.No behavior change; pure optimization.