Throw IllegalArgumentException when getManifest is called without Session and classpath is enabled#378
Open
elharo wants to merge 1 commit into
Open
Throw IllegalArgumentException when getManifest is called without Session and classpath is enabled#378elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
…sion and classpath is enabled The two-parameter getManifest(Project, ManifestConfiguration) passes null for Session. When addClasspath or addExtensions is enabled, doGetManifest dereferences the null session, causing a NullPointerException. Add a null check that throws an informative IllegalArgumentException telling callers to use the three-parameter overload with a non-null Session. Fixes apache#364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364
getManifest(Project, ManifestConfiguration)passesnullforSession. WhenaddClasspathoraddExtensionsis enabled,doGetManifest()dereferences the null session, causing aNullPointerException.This adds a null check that throws an informative
IllegalArgumentExceptiontelling callers to use the three-parameter overload with a non-nullSession.Test-first
doGetManifest()(green)