Skip to content

Fix #371: Cache model.getBuild() result to avoid repeated calls #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshMehta112 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Fix #371: Cache model.getBuild() result to avoid repeated calls #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/org/apache/maven/shared/archiver/BuildHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.Arrays;
import java.util.Map;

import org.apache.maven.api.model.Build;
import org.apache.maven.api.model.Model;
import org.apache.maven.api.model.Plugin;
import org.apache.maven.api.model.PluginContainer;
Expand Down Expand Up @@ -83,9 +84,10 @@ public static Plugin getCompilerPlugin(Model model) {
* @return the plugin from build or pluginManagement, if available in project
*/
public static Plugin getPlugin(Model model, String pluginGa) {
Plugin plugin = getPlugin(model.getBuild(), pluginGa);
if (model.getBuild() != null && plugin == null) {
plugin = getPlugin(model.getBuild().getPluginManagement(), pluginGa);
Build build = model.getBuild();
Plugin plugin = getPlugin(build, pluginGa);
if (build != null && plugin == null) {
plugin = getPlugin(build.getPluginManagement(), pluginGa);
}
return plugin;
}
Expand Down