Drop the surefire exclusion for a test that no longer exists - #1081
Merged
Conversation
The xdoc module excluded XmlWriterXdocSinkTest from surefire. That test was disabled in 2010 under DOXIA-408 because it failed on Windows and covered an already-deprecated feature, then deleted outright in 8e689f8 along with the rest of the deprecated code; XmlWriterXdocSink itself is gone too. The exclusion outlived both and now names a file that is not there. Removing it takes the whole build section with it, since the exclusion was the only thing in it. Verified: the xdoc module runs the same 134 tests before and after, so the exclusion was matching nothing
|
@slachiewicz Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xdoc module excludes
XmlWriterXdocSinkTestfrom surefire. That test was disabled in 2010 under DOXIA-408 — it failed on Windows and covered an already-deprecated feature — and was then deleted outright in8e689f84("[DOXIA-632] Remove remaining deprecated code"), along withXmlWriterXdocSinkitself. The exclusion outlived both and now names a file that is not there.Removing it takes the whole
<build>section with it, since the exclusion was the only thing in it.Verified: the module runs the same 134 tests before and after, so the exclusion was matching nothing.
This change was created with AI assistance.