Apply maven-args to the Set up Maven step#271
Merged
Conversation
The "Set up Maven" step bootstraps the Maven wrapper by running the
runner's system mvn against maven-wrapper-plugin:wrapper. Running any
goal in a project directory forces Maven to read the project model,
which includes resolving the parent POM -- but this step did not pass
${{ inputs.maven-args }}, unlike the later "Build with Maven" /
"Build Maven Site" steps.
A caller that injects a custom settings file via maven-args (for
example -s .github/settings.xml to reach a staged Apache parent POM
during a simultaneous parent vote) therefore could not influence parent
resolution in this first step, so the bootstrap failed with a
Non-resolvable parent POM error before the actual build ran.
Pass ${{ inputs.maven-args }} to the wrapper bootstrap in both the
fail-fast-build and verify jobs. The default value is benign, so this
is a no-op for callers that do not set maven-args.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hboutemy
approved these changes
Jun 27, 2026
Member
|
thank you |
hboutemy
added a commit
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Set up Mavenstep bootstraps the Maven wrapper by running the runner'ssystem
mvnagainstmaven-wrapper-plugin:wrapper:Running any goal in a project directory forces Maven to read the project model,
which includes resolving the parent POM — even though the goal itself only
writes wrapper files. This step does not pass
${{ inputs.maven-args }},unlike the later
Build with Maven/Build Maven Sitesteps.So a caller that injects a custom settings file via
maven-args(e.g.
-s .github/settings.xmlto reach a staged Apache parent POM during asimultaneous Apache-parent / project-parent vote) cannot influence parent
resolution in this first step. The bootstrap then fails with
Non-resolvable parent POM … org.apache:apache:pom:39 … in centralbefore theactual build ever runs.
Concrete failure: apache/maven-parent#578 →
https://github.com/apache/maven-parent/actions/runs/28279903879/job/83793460535
Fix
Pass
${{ inputs.maven-args }}to the wrapper bootstrap in both thefail-fast-buildandverifyjobs. The default value(
-D"invoker.streamLogsOnFailures") is benign, so this is a no-op for callersthat do not set
maven-args.