Skip to content

Conversation

@anukalp2804
Copy link

Clarified that getModel() is a temporary legacy accessor and will be removed once transform() is fully implemented. Added guidance to rely on the extract -> transform -> load pipeline instead.

This work is part of Issue #1436 – Document Deprecations and improves the deprecation documentation for ModelETL#getModel().

  • Confirmed this method is intentionally deprecated as a transitional API
  • Added Javadoc explaining why it is deprecated and what to use instead
  • No functional behavior changes
  • Successfully verified build using mvn clean install

Reference: #1436

/cc @elharo

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

* {@link #transform()} processing phase is fully implemented
* and callers no longer need to access the intermediate model
* directly.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete blank line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete blank line

Thanks for the review. I’ve removed the blank line as requested.

@anukalp2804 anukalp2804 force-pushed the doc-deprecation-modeletl branch from c828b26 to bb9e204 Compare January 5, 2026 12:37
Clarified that getModel() is a temporary legacy accessor and will be
removed once transform() is fully implemented. Added guidance to rely
on the extract -> transform -> load pipeline instead.
@anukalp2804 anukalp2804 force-pushed the doc-deprecation-modeletl branch from bb9e204 to 2bf5dba Compare January 5, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants