Skip to content

Xpp3DomBuilder.createXmlReader: remove thread-unsafe system property manipulation #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −11
Open

Xpp3DomBuilder.createXmlReader: remove thread-unsafe system property manipulation #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27191ff
Add test: Xpp3DomBuilder does not modify SAX driver system property
elharo Jul 1, 2026
2131f11
Xpp3DomBuilder.createXmlReader: remove thread-unsafe system property …
elharo Jul 1, 2026
add1fcb
spotless:apply formatting
elharo Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,7 @@ private static XMLReader createXmlReader() throws SAXException {
return comSunXmlReader;
}

String key = "org.xml.sax.driver";
String oldParser = System.getProperty(key);
System.clearProperty(key); // There's a "slight" problem with this an parallel maven: It does not work ;)

try {
return org.xml.sax.helpers.XMLReaderFactory.createXMLReader();
} finally {
if (oldParser != null) {
System.setProperty(key, oldParser);
}
}
return org.xml.sax.helpers.XMLReaderFactory.createXMLReader();
}

private static XMLReader instantiate(String s) {
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/org/apache/maven/shared/utils/xml/Xpp3DomBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ public void trimming() {
assertEquals(" preserve space ", dom.getChild("element6").getValue());
}

@Test
public void buildDoesNotModifySaxDriverProperty() {
String key = "org.xml.sax.driver";
String original = System.getProperty(key);
Xpp3DomBuilder.build(new StringReader("<root/>"));
assertEquals(original, System.getProperty(key));
}

@Test
public void testMalformedXml() {
try {
Expand Down
Loading