Xpp3Dom.removeChild(int): fix childMap corruption with duplicate names#395
Open
elharo wants to merge 1 commit into
Open
Xpp3Dom.removeChild(int): fix childMap corruption with duplicate names#395elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xpp3Dom.removeChild(int)(line 262) callschildMap.values().remove(child)to remove the child from the internal name-to-child map. This is incorrect when multiple children share the same name:childMapstores only the last child added with a given name (entries are overwritten byaddChild)values().remove(child)removes the first matching value — which is the only value for that name in the mapgetChild(name)correctly returns null but only by coincidence — the map entry was simply removedFix: After removing the child from
childList, check ifchildMappoints to that specific child (by reference). If so, scanchildListfor the last remaining child with the same name and update the map, or remove the entry if none remain.Fixes #394