Os.getOsFamily: return empty string instead of null#407
Closed
elharo wants to merge 1 commit into
Closed
Conversation
sparsick
reviewed
Jul 2, 2026
| return fam; | ||
| } | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
I didn't find a contract, that ensures this piece of code should not be null. I'm afraid, that could have side effects in code that uses it.
For example:
if (Os.OS_FAMILY == null) {
}This snippet would have another meaning after our change.
On the other side, the class Os is deprecated, so maybe it is okay to take this risk.
Contributor
Author
There was a problem hiding this comment.
Makes sense. probably better not to take it then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406