Merged
Conversation
They were broken since commit 308dd86. XML namespaces have names that look like URLs, but for historical reasons start with "http". Some of these were changed to "https" by mistake, which breaks strict XML validation and causes errors to show up in Eclipse when the POM is opened. Correct this such that namespace names always have "http", but XSD locations have "https" URLs.
Make sure that the maven-source-plugin uses a modern commons-io. Somehow it picks up 2.11.0, which is way too old. Force 2.20.0. Set deployAtEnd=true to avoid that anything is pushed to the deployment repository if something goes wrong when building a release. This is a partial back-port of commit aa9c94b.
To be able to build with Java 25.
Bouncy Castle 1.82 -> 1.83 Jsch 2.27.4 -> 2.27.7
Also use the maven wrapper instead of setting up maven via a Github action.
It makes no sense to install unsupported key exchange factories. This makes CipherTest fail on Java 25 when run as part of the sshd-mina (and probably also sshd-netty) tests, which do not include BouncyCastle. Without BC, MLKEM is not supported with 2.17.0, but the test uses JSch as client, which will propose MLKEM when run on Java 25. If the server includes the unsupported MLKEM KEX in its proposal, this will get selected and then cause a NoClassDefFoundError exception later in the Apache MINA SSHD test server, making the test fail. On Java 21, JSch does not propose MLKEM, so the test worked because the unsupported KEX algorithm was not selected (curve-25519-sha256 is used instead). Simply don't ever install unsupported KEX algorithms.
org.junit.jupiter 5.14.0 -> 5.14.2
We do not want to pick up any real config of the user running the tests! Such configs may contain settings that break our tests. Also mock the home directory for JGit, and hide some environment variables that could potentially affect JGit adversely if set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.