OMID-319 Use shaded protobuf-java from phoenix-thirdparty #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meszinorbi
force-pushed
the
protobuf-shaded
branch
2 times, most recently
from
23459dd to
bbbb6c6
Compare
meszinorbi
changed the title
meszinorbi
force-pushed
the
protobuf-shaded
branch
from
fb4ac74 to
beae783
Compare
stoty
reviewed
Sep 18, 2025
|
|
||
| import java.util.List; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Please add a note explaining where this was copied from and why
|
|
||
| import static io.netty.buffer.Unpooled.wrappedBuffer; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Please add a note explaining where this was copied from and why
meszinorbi
force-pushed
the
protobuf-shaded
branch
from
beae783 to
ebbed11
Compare
stoty
reviewed
Sep 18, 2025
meszinorbi
force-pushed
the
protobuf-shaded
branch
from
c9cb339 to
99c51a4
Compare
meszinorbi
force-pushed
the
protobuf-shaded
branch
2 times, most recently
from
4193650 to
190d9f7
Compare
Contributor
|
Why aren't the github actions tests running ? |
meszinorbi
force-pushed
the
protobuf-shaded
branch
from
190d9f7 to
5d98046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.