fix: fix connection panic caused by WaitGroup misuse on close#1484
Open
nodece wants to merge 1 commit intoapache:masterfrom
Open
fix: fix connection panic caused by WaitGroup misuse on close#1484nodece wants to merge 1 commit intoapache:masterfrom
nodece wants to merge 1 commit intoapache:masterfrom
Conversation
ed778ba to
f070589
Compare
f070589 to
154a0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1483
Motivation
When the connection is closed while
SendRequest/SendRequestNoWaitare in flight,failLeftRequestsWhenClosecallsWait()on the WaitGroup. Concurrent goroutines that pass thegetState()check may still callAdd(1), triggeringsync: WaitGroup is reused before previous Wait has returnedpanic in Go 1.25+.Modifications
Add(1)underc.mu.RLock()inSendRequestandSendRequestNoWait.Close()sets state underc.mu.Lock(), so the check-and-add is atomic with respect toClose(). After state is set toconnectionClosed, no newAdd(1)can happen, ensuringWait()will always return.Wait(). SinceWait()guarantees all requests are already enqueued, a non-blocking drain is sufficient for strict correctness.