Skip to content

fix: add batchIdx to messageID.String() when batched message#1491

Merged
nodece merged 2 commits intoapache:masterfrom
adrianiacobghiula:master
May 10, 2026
Merged

fix: add batchIdx to messageID.String() when batched message#1491
nodece merged 2 commits intoapache:masterfrom
adrianiacobghiula:master

Conversation

@adrianiacobghiula
Copy link
Copy Markdown
Contributor

@adrianiacobghiula adrianiacobghiula commented May 8, 2026

Motivation

MessageID contains a batchIdx that is being skipped on String(), adding the same functionality as in java - BatchMessageIdImpl overrides the toString() to add the batchId

Modifications

add batchIdx if > -1

Verifying this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@adrianiacobghiula
Copy link
Copy Markdown
Contributor Author

@nodece I fixed the broken integration test -> you can check first the execution on my repo https://github.com/adrianiacobghiula/pulsar-client-go/actions/runs/25611371370

@nodece nodece merged commit d664fcf into apache:master May 10, 2026
11 of 12 checks passed
@nodece
Copy link
Copy Markdown
Member

nodece commented May 10, 2026

@adrianiacobghiula Good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants