fix: add batchIdx to messageID.String() when batched message#1491
Merged
nodece merged 2 commits intoapache:masterfrom May 10, 2026
Merged
fix: add batchIdx to messageID.String() when batched message#1491nodece merged 2 commits intoapache:masterfrom
nodece merged 2 commits intoapache:masterfrom
Conversation
nodece
approved these changes
May 9, 2026
Contributor
Author
|
@nodece I fixed the broken integration test -> you can check first the execution on my repo https://github.com/adrianiacobghiula/pulsar-client-go/actions/runs/25611371370 |
Member
|
@adrianiacobghiula Good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MessageID contains a batchIdx that is being skipped on String(), adding the same functionality as in java - BatchMessageIdImpl overrides the toString() to add the batchId
Modifications
add batchIdx if > -1
Verifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation