fix(security): 2 improvements across 2 files#1492
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Integer Overflow in Negative Ack Backoff Policy - Security: Potential SSRF via Issuer URL in OIDC Endpoint Provider Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Integer Overflow in Negative Ack Backoff Policy - Security: Potential SSRF via Issuer URL in OIDC Endpoint Provider Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:pulsar/negative_backoff_policy.go:L30In pulsar/negative_backoff_policy.go, the backoff calculation uses bit shift (minNackTime << redeliveryCount) which can overflow when redeliveryCount is large. The overflow causes backoff to become 0, resulting in immediate retry without any delay, potentially causing a denial of service.
Solution
Add overflow check before the shift operation: if redeliveryCount >= 63 { return maxNackTime }. Also consider using math.Min with a pre-computed maximum to avoid the overflow entirely.
Changes
pulsar/negative_backoff_policy.go(modified)oauth2/oidc_endpoint_provider.go(modified)