[fix][io] Fix delayed acknowledgment for offset 0 in Kafka Connect Adapter#24
Open
sandeep-mst wants to merge 2 commits intoapache:masterfrom
Open
[fix][io] Fix delayed acknowledgment for offset 0 in Kafka Connect Adapter#24sandeep-mst wants to merge 2 commits intoapache:masterfrom
sandeep-mst wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
Motivation
PulsarKafkaSinkTaskContext.currentOffsets() was filtering out offsets equal to
0by only including values greater than0. This caused the first record in a partition, whose offset can legitimately be0, to be omitted from the offsets snapshot returned to KafkaConnectSink#flush(). As a result, the acknowledgment for that record was not flushed until a later record with a non-zero offset was processed.This change ensures that offset
0is treated as a valid offset and is included in the current offsets map, so the first record can be acknowledged without waiting for another record.Modifications
The offset filter in PulsarKafkaSinkTaskContext.currentOffsets() was changed from:
if (offset > 0) {to:
if (offset >= 0) {This includes records with offset
0in the returned snapshot.A assertion was added to existing
offsetTestinKafkaConnectSinkTestto verify thatcurrentOffsets()contains that record and reports offset 0 correctly.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
cognitree#6