Skip to content

docs: Add missing enableRetry configuration to producerBuilderCustomizer DeadLetterPolicy example#1041

Merged
lhotari merged 4 commits intoapache:mainfrom
sundar-ka:docs/consumer-enable-retry-config
May 4, 2026
Merged

docs: Add missing enableRetry configuration to producerBuilderCustomizer DeadLetterPolicy example#1041
lhotari merged 4 commits intoapache:mainfrom
sundar-ka:docs/consumer-enable-retry-config

Conversation

@sundar-ka
Copy link
Copy Markdown
Contributor

✅ Contribution Checklist

@sundar-ka sundar-ka changed the title setting enableRetry as true in consumer config docs: Add missing enableRetry configuration to consumer example Sep 23, 2025
Copy link
Copy Markdown
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an .enableRetry(true) example in the "Retry letter topic" docs. Using the "dead letter topic" feature doesn't require enabling the "retry letter topic" feature so that's why the change could be misleading.
I'd suggest improving the descriptions of "retry letter topic" and "dead letter topic" to explain the connection between these 2 features.

Copy link
Copy Markdown
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the previous review. This change is fine. I updated it to target currently maintained document versions.

@lhotari lhotari changed the title docs: Add missing enableRetry configuration to consumer example docs: Add missing enableRetry configuration to producerBuilderCustomizer DeadLetterPolicy example May 4, 2026
@lhotari lhotari merged commit 5f39d5c into apache:main May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants