[improve][cli]Support for pulsar-shell persistent modes#22522
[improve][cli]Support for pulsar-shell persistent modes#22522sandeep-mst wants to merge 7 commits intoapache:masterfrom
Conversation
lhotari
left a comment
There was a problem hiding this comment.
Good work @sandeep-mst . A few minor review comments.
nicoloboschi
left a comment
There was a problem hiding this comment.
I like this idea.
-
I think we should register the new commands like other commands in
registerProviders(..)so automatic autocompletion will work for these modes too. -
I don't understand the title, what do you mean by persistent modes ? I think we need a better name for this feature.
-
We should add docs, at least in the help (might be mitigated by 1.)
spaces where required, single line variable, promptmessage value stays the same but the prompt varies
@sandeep-mst Have you considered addressing @nicoloboschi's review feedback? For example, windows netsh has the concept of contexts and subcontexts (top level is "context", which could have "subcontexts"). |
…Mode which will help in auto-completion
Hi @lhotari,
|
Fixes 21194 of apache/pulsar
Motivation
Pulsar shell doesn't support persistent mode for admin, client, config. If we need to run a lot of admin commands for example, we would need to prefix admin each time. This will provide an alternative approach.
Modifications
Modified so that
admin,client,configcommands individually will launch their own mode and prompt message also gets updated.exitorquitcommand will exit from the mode to the default mode.In the admin mode, we can run command
topicsinstead ofadmin topics.Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
cognitree#6