[improve][test] Add filtering solution for fast selection of TestNG groups#24921
Draft
lhotari wants to merge 3 commits intoapache:masterfrom
Draft
[improve][test] Add filtering solution for fast selection of TestNG groups#24921lhotari wants to merge 3 commits intoapache:masterfrom
lhotari wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
/pulsarbot rerun-failure-checks |
1dccf3a to
b8413d0
Compare
Member
Author
|
There's a difference in the number of executed tests for some reason. Would have to check further to find out the difference. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When executing tests with Surefire & TestNG, there's a lot of overhead caused by the test filtering. It takes 1-2 seconds to evaluate whether each test class belongs to the test group since TestNG instantiates each test class, runs configured listeners and then decides whether the class belongs to the test group.
Since there's a lot of test classes in pulsar-broker, a lot of unnecessary time is spent in each broker group test job just to filter out tests.
This solution will reduce the duration of each test job and allow further splitting of pulsar-broker tests to be run in separate test jobs in CI.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete