Skip to content

[fix][broker] include segment descriptor in underlying topic name#25709

Open
Dream95 wants to merge 1 commit intoapache:masterfrom
Dream95:fix_segment_topic_name
Open

[fix][broker] include segment descriptor in underlying topic name#25709
Dream95 wants to merge 1 commit intoapache:masterfrom
Dream95:fix_segment_topic_name

Conversation

@Dream95
Copy link
Copy Markdown
Contributor

@Dream95 Dream95 commented May 7, 2026

Motivation

The underlying persistent topic name for a scalable topic segment should include the segment descriptor, for example persistent://tenant/ns/my-topic/0000-ffff-0.

Modifications

Include the segment descriptor when converting a scalable segment topic name to its underlying persistent:// topic name.
The generated name now preserves the segment suffix, changing from persistent://tenant/ns/my-topic to persistent://tenant/ns/my-topic/0000-ffff-0.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Matching PR in forked repository

PR in forked repository: Dream95#8

Signed-off-by: Dream95 <zhou_8621@163.com>
@merlimat
Copy link
Copy Markdown
Contributor

merlimat commented May 7, 2026

@Dream95 Thanks for pointing this out. The fix was bigger than this though. I've created #25717 to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants