[fix][broker] include segment descriptor in underlying topic name#25709
Open
Dream95 wants to merge 1 commit intoapache:masterfrom
Open
[fix][broker] include segment descriptor in underlying topic name#25709Dream95 wants to merge 1 commit intoapache:masterfrom
Dream95 wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Dream95 <zhou_8621@163.com>
5 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The underlying persistent topic name for a scalable topic segment should include the segment descriptor, for example
persistent://tenant/ns/my-topic/0000-ffff-0.Modifications
Include the segment descriptor when converting a scalable segment topic name to its underlying
persistent://topic name.The generated name now preserves the segment suffix, changing from
persistent://tenant/ns/my-topictopersistent://tenant/ns/my-topic/0000-ffff-0.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Matching PR in forked repository
PR in forked repository: Dream95#8