RANGER-5407: In Atlas Service for some of the default policies wrong permissions seen (PatchSet-2) #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshkumar-yadav
requested review from
kishorgollapalliwar,
mneethiraj and
pradeepagrawal8184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the Atlas service, incorrect permissions are observed in some default policies, particularly after upgrade.
Below are the policies name where we are seeing this issue
all – entity-type, entity-classification, entity
all – entity-type, entity-classification, entity, entity-business-metadata
all – entity-type, entity-classification, entity, entity-label
Steps to reproduce
Upgrade Ranger from ranger-2.1 to master
In the Ranger Admin UI, navigate to the Atlas policy listing page.
Open (view) any of the above-mentioned policies.
Observed behavior:
On the policy view page, unexpected permissions are displayed that are not available during policy create or edit.
This includes:
The entity-read permission appearing in policies where it is not expected
Classification-related permissions such as:
entity-add-classification
entity-update-classification
entity-remove-classification{}
Specifically, classification permissions are visible within the entity-read policy.
How was this patch tested?
Verified that incorrect policy-item permissions are now moved to their appropriate policies.