[SPARK-57789] Update and bundle LICENSE-binary and licenses-binary to describe all bundled libraries#721
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57789] Update and bundle LICENSE-binary and licenses-binary to describe all bundled libraries#721dongjoon-hyun wants to merge 1 commit into
LICENSE-binary and licenses-binary to describe all bundled libraries#721dongjoon-hyun wants to merge 1 commit into
Conversation
viirya
previously approved these changes
Jun 30, 2026
LICENSE-binary and add licenses-binary to describe all bundled librariesLICENSE-binary and licenses-binary to describe all bundled libraries
Member
Author
|
Since we use |
f72224e to
43a1346
Compare
2a7a11a to
8980974
Compare
…` to describe all bundled libraries
8980974 to
f611562
Compare
Member
Author
|
Now, this PR is ready. Could you review this, too, @viirya and @peter-toth ? |
viirya
approved these changes
Jul 2, 2026
peter-toth
approved these changes
Jul 2, 2026
Member
Author
|
Thank you so much, @viirya and @peter-toth ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
LICENSE-binaryto describe all third-party libraries bundled in the operatorshadow jar, adds the
licenses-binary/directory with the license texts of the non-Apachecomponents, and bundles them into the jar like Apache Hadoop's
hadoop-client-runtime.LICENSE-binary: rewritten in Apache Spark'sLICENSE-binaryformat, listing the 170 bundledartifacts grouped by license. The list was verified against the actual shadow jar contents.
licenses-binary/: adds the 11 license texts for the non-Apache-licensed components.spark-operator/build.gradle: the shadow jar now shipsLICENSE-binary/NOTICE-binaryasMETA-INF/LICENSE/META-INF/NOTICEplusMETA-INF/licenses-binary/, instead of thesource-release
LICENSE/NOTICE..github/.licenserc.yaml: skips the header check forlicenses-binary/**.Why are the changes needed?
LICENSE-binarywas a copy ofLICENSEand did not enumerate any bundled dependency. Per theASF licensing policy, a convenience binary must account for all bundled licenses and include the non-Apache license texts.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Manually verified that
META-INF/LICENSEin the shadow jar is identical toLICENSE-binary, andthat every listed artifact actually has classes in the shadow jar (relocation-aware comparison
against the original jars from Maven Central).
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5