[SPARK-55799][PYTHON][TESTS] Add datasource tests with simple worker#54580
Open
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55799][PYTHON][TESTS] Add datasource tests with simple worker#54580gaogaotiantian wants to merge 2 commits intoapache:masterfrom
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Conversation
holdenk
reviewed
Mar 2, 2026
Comment on lines
+226
to
+230
| def is_pyspark_module(frame: FrameType) -> bool: | ||
| module_name = frame.f_globals.get("__name__", "") | ||
| if module_name == "__main__": | ||
| if mod := sys.modules.get("__main__", None): | ||
| module_name = mod.__spec__.name |
Contributor
There was a problem hiding this comment.
just so i understand, these logging changes were needed/discovered after adding the test or just a cleanup?
Contributor
Author
There was a problem hiding this comment.
This is needed for the test. The original code did not consider the simple worker case, where the worker module is executed with python -m XXX - the __name__ would be __main__ and our method to check if it's pyspark module will give a wrong result.
allisonwang-db
approved these changes
Mar 3, 2026
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
is_pyspark_modulein worker logging so it can recognize simple workersWhy are the changes needed?
We support simple worker for data source but we have 0 test for it. Some issues were already fixed in the previous PRs and this is the one to enable the test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
test_python_datasourcepassed locally.Was this patch authored or co-authored using generative AI tooling?
No.