refactor ClassUtils.getResourceAsStream to simplify the implementation

[verhasi]

No functional modification applied just simplified the implementation to make it more readable.

[michael-o]

What is the benefit to move a single line to method which is used only once?

[michael-o]

Moveover, this requires compiling a regexp every single time.

[verhasi]

The trigger for moving to a separate method was the smelling inline comment (that is not a Javadoc). At first, it was three lines of code and after moving I refactored it to an oneliner. I still see it as better readable as the method has a meaningful name.
Regarding the performance. The starting point was a cycle that created a new String object for each starting slash. Depending on the number of starting slashes the replaceFirst is an enhancement. On the other hand, I agree with you this could be split into a static compiled pattern and a matching part.

[michael-o]

Isn't startsWith and substring cheap enough?

[verhasi]

We can go ahead with startsWith and substring. I propose the following:

    /**
     * remove leading slash(es) so path will work with classes in a JAR file
     */
    private static String removeLeadingSlash(String name)
    {
        int i = 0;
        while (name.startsWith("/",i)) i++;
        return i>0 ? name.substring(i) : name;
    }

It performs the same in case of 0 or 1 slash, but I am sure it is faster in case the number of slashes is greater than 1.