-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI #5101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d6228ac to
b07b933
Compare
|
Could you rebase this onto master branch? |
tbonelee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a quick pass on two areas?
- There are places where try/catch accepts both error and non-error paths. Could we make these more explicit, either intentionally silencing with a clear rationale or failing, so we reduce false positives?
- For browser-specific branches (e.g., notebook-keyboard-page.ts → executePlatformShortcut), could we extract that logic so the main flow reads sequentially and the differences are isolated?
zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts
Outdated
Show resolved
Hide resolved
zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts
Outdated
Show resolved
Hide resolved
zeppelin-web-angular/e2e/models/notebook-action-bar-page.util.ts
Outdated
Show resolved
Hide resolved
d058c16 to
9bd2f40
Compare
1dc6ffa to
f4f51b1
Compare
50eed38 to
07b58b4
Compare
f069171 to
1d263ec
Compare
ba47403 to
3f5582c
Compare
|
It took some time to incorporate the review feedback, do incremental refactoring, and clean up the tests that were failing in CI.
Once all of those PRs are merged, we can close the current PR accordingly. |
375098e to
4993ecd
Compare
What is this PR for?
Addition and improvement of notebook-related E2E tests for New UI
/#/notebook/:noteId – View or edit a specific notebook
/#/notebook/:noteId/revision/:revisionId – View a specific revision of a notebook
/#/notebook/:noteId/paragraph/:paragraphId – Notebook paragraph presentation mode
PAGES.WORKSPACE.NOTEBOOK
→ src/app/pages/workspace/notebook/notebook.component
PAGES.WORKSPACE.NOTEBOOK_ACTION_BAR
→ src/app/pages/workspace/notebook/action-bar/action-bar.component
PAGES.WORKSPACE.NOTEBOOK_PARAGRAPH
→ src/app/pages/workspace/notebook/paragraph/paragraph.component
PAGES.WORKSPACE.NOTEBOOK_SIDEBAR
→ src/app/pages/workspace/notebook/sidebar/sidebar.component
PAGES.WORKSPACE.PUBLISHED_PARAGRAPH
→ src/app/pages/workspace/published/paragraph/paragraph.component
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
Screenshots (if appropriate)
Questions: