chore: bump ngx_multi_upstream_module to 1.3.4 - #490
Merged
Merged
Conversation
|
Warning Review limit reached
On-demand reviews are free for the next 25 days. After that, they cost $0.25 per reviewed file. Or wait 58 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
nic-6443
approved these changes
Aug 26, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up api7/ngx_multi_upstream_module#22, a use-after-free that crashes the worker.
ngx_http_multi_upstream_connection_close()destroyedc->pooland then calledngx_close_connection(c), which still logs throughc->log— and for these upstream connectionsc->loglives in the pool that was just released. On a debug-enabled build thengx_log_debug1(..., "reusable connection: %ui")insidengx_reusable_connection()reads a freedngx_log_tand handsngx_write_fd()a garbage descriptor.It shows up as an intermittent SIGSEGV on APISIX's
t/plugin/dubbo-proxy/upstream.tTEST 1 (roughly one run in three locally against 1.3.16, and it took out a CI shard on apache/apisix#13863 once).