-
Notifications
You must be signed in to change notification settings - Fork 38
feat(actors): enables standby mode via actor.json #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
l2ysho
wants to merge
3
commits into
master
Choose a base branch
from
913-actorjson-option-usesstandbymode-does-not-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−1
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,18 @@ const DEFAULT_ACTOR_VERSION_NUMBER = '0.0'; | |
| // that changes, we have to add it. | ||
| const DEFAULT_BUILD_TAG = 'latest'; | ||
|
|
||
| // Default standby mode configuration when usesStandbyMode is enabled in actor.json | ||
| const DEFAULT_STANDBY_OPTIONS = { | ||
| isEnabled: true, | ||
| disableStandbyFieldsOverride: false, | ||
| maxRequestsPerActorRun: 4, | ||
| desiredRequestsPerActorRun: 3, | ||
| idleTimeoutSecs: 300, | ||
| build: 'latest', | ||
| memoryMbytes: 1024, | ||
| shouldPassActorInput: false, | ||
| }; | ||
|
|
||
| export class ActorsPushCommand extends ApifyCommand<typeof ActorsPushCommand> { | ||
| static override name = 'push' as const; | ||
|
|
||
|
|
@@ -196,17 +208,30 @@ export class ActorsPushCommand extends ApifyCommand<typeof ActorsPushCommand> { | |
| }, | ||
| ], | ||
| }; | ||
|
|
||
| // Enable standby mode if configured in actor.json | ||
| if (actorConfig!.usesStandbyMode) { | ||
| newActor.actorStandby = DEFAULT_STANDBY_OPTIONS as ActorCollectionCreateOptions['actorStandby']; | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ActorCollectionCreateOptions type look little bit out of date -> StandBy type missing |
||
| } | ||
|
|
||
| actor = await apifyClient.actors().create(newActor); | ||
| actorId = actor.id; | ||
| isActorCreatedNow = true; | ||
| info({ message: `Created Actor with name ${actorConfig!.name} on Apify.` }); | ||
| } | ||
| } | ||
|
|
||
| const actorClient = apifyClient.actor(actorId); | ||
|
|
||
| // Update standby mode on existing actor if configured in actor.json but not enabled on actor | ||
| if (!isActorCreatedNow && actorConfig!.usesStandbyMode && !actor.actorStandby?.isEnabled) { | ||
| await actorClient.update({ actorStandby: DEFAULT_STANDBY_OPTIONS }); | ||
| info({ message: 'Enabled standby mode for Actor.' }); | ||
| } | ||
|
|
||
| info({ message: `Deploying Actor '${actorConfig!.name}' to Apify.` }); | ||
|
|
||
| const filesSize = await sumFilesSizeInBytes(filePathsToPush, cwd); | ||
| const actorClient = apifyClient.actor(actorId); | ||
|
|
||
| let sourceType; | ||
| let sourceFiles; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stole this from console.apify.com, it is default preset send when user just enable standby mode. cc @vladfrangu
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my idea was result should be the same no matter if I use CLI or console UI