Skip to content

chore(deps): update pnpm to v11.7.0 - #2644

Merged
B4nan merged 4 commits into
masterfrom
claude/infallible-nobel-3a9395
Jun 17, 2026
Merged

chore(deps): update pnpm to v11.7.0#2644
B4nan merged 4 commits into
masterfrom
claude/infallible-nobel-3a9395

Conversation

@B4nan

@B4nan B4nan commented Jun 16, 2026

Copy link
Copy Markdown
Member

Updates pnpm from v10.33.4 to v11.7.0, replacing Renovate's #2601.

Renovate only bumped packageManager, which devEngines.packageManager overrides, so CI stayed on v10. This bumps both version fields and handles two pnpm v11 behavior changes:

  • pnpm v11 enables strictDepBuilds by default and fails the install on undeclared build scripts (ERR_PNPM_IGNORED_BUILDS) - the previously ignored build scripts are now declared via allowBuilds in pnpm-workspace.yaml.
  • devEngines.packageManager.onFail is set to error to disallow other package managers; the lone npm run step in CI is switched to pnpm so it no longer trips EBADDEVENGINES. On pnpm v11 this also records the pnpm binary into pnpm-lock.yaml as a leading packageManagerDependencies document (intended behavior).

Renovate's #2601 only bumped `packageManager`, but `devEngines.packageManager`
took precedence and kept CI on v10, and pnpm v11 enables `strictDepBuilds` by
default which fails the install on undeclared build scripts (ERR_PNPM_IGNORED_BUILDS).

Bump both version fields and declare the previously ignored build scripts via
`allowBuilds` so the install matches the pnpm v10 behavior.
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 16, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 16, 2026
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Jun 16, 2026
@apify-service-account

apify-service-account commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🗑️ Preview for this PR was deleted.

B4nan added 3 commits June 16, 2026 14:16
With `devEngines.packageManager.onFail: warn`, pnpm v11 records the pnpm
binary into pnpm-lock.yaml as a `packageManagerDependencies` document,
prepending a second YAML document to the lockfile. Set `onFail: ignore`
so pnpm leaves the lockfile untouched - the `packageManager` field and
CI's pnpm setup already enforce the version.
Use `onFail: error` so npm/yarn refuse to install in this repo (they read
`devEngines.packageManager`), disallowing other package managers. On pnpm v11
this records the pnpm binary into pnpm-lock.yaml as a `packageManagerDependencies`
document - the original lockfile is preserved verbatim as the second document.
`onFail: error` makes npm refuse to run, so the `npm run test:llms-size`
step failed with EBADDEVENGINES. This was the only non-pnpm invocation in
the repo - switch it to pnpm, consistent with the rest of CI.
@B4nan
B4nan requested a review from vladfrangu June 16, 2026 12:37
Comment thread pnpm-workspace.yaml
Comment on lines +40 to +46
"@apify/ui-icons": false
"@parcel/watcher": false
"@swc/core": false
core-js: false
core-js-pure: false
postman-code-generators: false
protobufjs: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we do not want to deny these but approve, no?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely not all of them, e.g. core-js just spams with a sponsor message. i would guess if something is needed, the CI would be red? the preview also looks good to me (but i did only a quick comparison)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all ran ignored throughout the pnpm 10 era (pnpm 10 only warned, pnpm 11 errors), so false keeps the behavior production has shipped on — true would newly enable build steps we've safely skipped for ages. Checked each:

  • core-js/core-js-pure: postinstall is just the OpenCollective sponsor message.
  • @swc/core, @parcel/watcher: native bindings come from prebuilt platform packages (@swc/core-*, @parcel/watcher-*); the build script only compiles from source as a fallback.
  • @apify/ui-icons: its create-barrel-file output (dist/index.js, index.css, index.d.ts) already ships in the published package.
  • postman-code-generators, protobufjs: postinstalls aren't needed for the generated docs — confirmed by green CI + the preview.

Nothing here is needed at build time; if it were, the Docs build would be red.

@B4nan
B4nan requested a review from vladfrangu June 17, 2026 12:22
@B4nan
B4nan merged commit 2c8a7d0 into master Jun 17, 2026
17 checks passed
@B4nan
B4nan deleted the claude/infallible-nobel-3a9395 branch June 17, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants