fix(ci): repair theme publish version bump and commit-back - #2660
Merged
Conversation
github-actions
Bot
added
the
t-tooling
Contributor
|
🗑️ Preview for this PR was deleted. |
The publish-theme workflow was failing at "Bump the theme version" with ERR_PNPM_UNCLEAN_WORKING_TREE. Root cause: the "Commit the new theme version" step has been silently failing since the repo migrated to pnpm because it tried to `git add` apify-docs-theme/package-lock.json, which doesn't exist in a pnpm repo (it's pnpm-lock.yaml). With continue-on-error: true, the job stayed green while the bumped version was never committed back, so the repo's package.json drifted behind npm (1.0.248 vs 1.0.251). `pnpm pkg set version=$LATEST` then writes a diff, dirtying the tree, and `pnpm version patch` refuses to run on a dirty tree. Fixes: - Compute the next patch version with `semver -i patch` and write it via `pnpm pkg set`, avoiding pnpm's clean-tree check entirely so the bump is robust even if the committed version drifts. - Drop the non-existent package-lock.json from the commit-back `add` list and remove continue-on-error so this never silently breaks again. - Re-sync the committed theme version (1.0.251) with npm latest.
barjin
force-pushed
the
fix/theme-publish-version-bump
branch
from
June 19, 2026 09:12
4902975 to
bcb2da8
Compare
szaganek
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing the
publish-themeworkflow (see failing run)The
Commit the new theme versionstep has been silently failing since the repo migrated topnpm(as there is nopackage-lock.jsonfile anymore.