Skip to content

feat: revamp the shared navbar - #2679

Merged
barjin merged 5 commits into
masterfrom
feat/navbar-revamp
Jun 26, 2026
Merged

feat: revamp the shared navbar#2679
barjin merged 5 commits into
masterfrom
feat/navbar-revamp

Conversation

@barjin

@barjin barjin commented Jun 23, 2026

Copy link
Copy Markdown
Member

Revamps the shared docs-theme navbar according to the Figma design.

image

Closes #2678

@barjin barjin self-assigned this Jun 23, 2026
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 23, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 23, 2026
@apify-service-account

apify-service-account commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🗑️ Preview for this PR was deleted.

@barjin
barjin requested a review from TC-MO June 23, 2026 11:25
@barjin

barjin commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

See https://pr-2679.preview.docs.apify.com/academy for the double navbar

image

@TC-MO

TC-MO commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Looking good!

Few questions/thoughts/comments

Few things differ slightly from Figma is that on purpose?

  • discord icon
  • Ask AI button (lack of the icon)

Few thoughts on how it looks

  • Discord icon is currently barely visible on dark mode
image

I see you also already wired top nav to use the specific folders so question whether I should contribute redirects and folder moves that are still necessary work before this ships on top of that PR or should we somehow split it? Let me know which makes more sense, I originally thought that we could split that into two separate PRs

  1. Update of the design while keeping the current items in top nav + current behaviour
  2. Folder moves & redirects that ship separately.

@barjin

barjin commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

The rendering discrepancies have been solved in 006d0ab

Regarding the contents of the navbar, I'm fine with either way (even having the new navbar link to the existing docs and fixing the links later on).

Anyway, I just reverted the changes to have the current navbar in the preview. Let me know if you want to merge it like this or make any changes 👍

@TC-MO TC-MO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, LGTM, we can merge this revamped navbar today, I'll work on the new items & redirects today so we can double check on Monday and hopefully release. Thanks a lot for this!

@barjin
barjin merged commit 478ff89 into master Jun 26, 2026
16 checks passed
@barjin
barjin deleted the feat/navbar-revamp branch June 26, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new top-nav design

3 participants