Skip to content

fix(scrapy): skip a request that fails to convert instead of crashing the run - #952

Merged
vdusek merged 3 commits into
masterfrom
fix/scrapy-scheduler-skip-bad-request
Jun 9, 2026
Merged

fix(scrapy): skip a request that fails to convert instead of crashing the run#952
vdusek merged 3 commits into
masterfrom
fix/scrapy-scheduler-skip-bad-request

test(scrapy): cover next_request skipping an unconvertible queue entry

a204b58
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 9, 2026 in 0s

87.08% (+0.69%) compared to 10203bc

View this Pull Request on Codecov

87.08% (+0.69%) compared to 10203bc

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.08%. Comparing base (10203bc) to head (a204b58).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   86.38%   87.08%   +0.69%     
==========================================
  Files          48       48              
  Lines        2916     2973      +57     
==========================================
+ Hits         2519     2589      +70     
+ Misses        397      384      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.