Skip to content

Conversation

@Mantisus
Copy link
Collaborator

Description

  • Fix race condition when concurrent creating storage.

Issues

Testing

  • Add new tests for StorageInstanceManager

@Mantisus Mantisus requested a review from vdusek December 17, 2025 22:55
@Mantisus Mantisus assigned janbuchar and Mantisus and unassigned janbuchar Dec 17, 2025
@Mantisus Mantisus requested a review from janbuchar December 17, 2025 22:55
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (30f8e15) to head (5183f2c).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/crawlee/storages/_storage_instance_manager.py 93.02% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
- Coverage   92.48%   92.46%   -0.02%     
==========================================
  Files         157      157              
  Lines       10421    10437      +16     
==========================================
+ Hits         9638     9651      +13     
- Misses        783      786       +3     
Flag Coverage Δ
unit 92.46% <93.02%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Mantisus and others added 2 commits December 18, 2025 14:52
@Mantisus Mantisus requested a review from janbuchar December 18, 2025 13:23
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vdusek vdusek merged commit 7f17a43 into apify:master Dec 19, 2025
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset get_data() returns fewer items than successfully pushed with context.push_data() in PlaywrightCrawler

3 participants