prototype: explicit deduplication clone opt-out - #438
Draft
trippyogi wants to merge 2 commits into
Draft
Conversation
|
@trippyogi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
This was referenced Aug 15, 2026
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a design prototype for #433, not an upstream-ready fix.
The investigation exposed a compatibility constraint: eliminating per-consumer deep clones under high-fanout deduplication also eliminates the existing guarantee that each caller receives an independently mutable parsed body.
This branch preserves current isolation semantics by default, removes the unnecessary clone when a request-lifetime request has only one consumer, and prototypes an explicit
shouldCloneParsedBodyForDeduplication()opt-out for consumers that treat parsed responses as immutable.The remaining question is API/behavioral rather than implementation correctness: whether Apollo wants a dedicated opt-out like this, prefers the existing
cloneParsedBodyoverride, or wants a different deduplication policy/configuration surface.Test plan
npm testdeduplicate-until-invalidated