Feat/wheel service details - #53
Merged
Merged
Conversation
DIMENSION_SUB_KEYS stays the survey vocabulary that established_subcat_keys() text-matches. The 14 interview-coded sub-keys move to a new DIMENSION_INTERVIEW_SUB_KEYS, never text-matched: service_matches_label() is prefix-tolerant, so free text 'Mindfulness' would capture wellness_spiritual_mindfulness_embedded and 'Daily meals for teens' would capture wellness_physical_meals, tagging orgs with services no coder assigned. DIMENSION_ALL_SUB_KEYS is the derived union used for display and filtering. Also drops a stale comment describing a <dim>_other catch-all removed earlier, and rewrites check_label_collisions.R's header now that its premise holds structurally.
interview_subcat_keys() reads other_services, gated to survey-established dimensions and to declared taxonomy keys. org_subcat_keys() unions it with established_subcat_keys(); both the details wheel (data-active-subcats) and the organizations cards (data-established-subcats) now read through it, so a filter hit and the wheel cannot disagree. Previously the cards used survey-only matching, so new filter checkboxes would have matched zero orgs. WHEEL_META extended to match, with a test that parses app.js and compares against DIMENSION_ALL_SUB_KEYS.
Plaintext English-only data/service_details.json maps irb_participant_id -> dimension -> sub_key -> text, authored by hand one org at a time; a .enc file would make every small edit an unreviewable binary diff. get_service_details() scopes text to the keys the wheel actually renders and drops blank values, so partial coverage is safe and an unwritten service renders no box. subcat_details_attr() returns NULL when empty so Shiny omits the attribute entirely. createWheel stacks the box under the label inside a new .subcat-body element, since .subcats li is a flex row; text is HTML-escaped as this is the first hand-authored prose in the panel string. Includes YSP04 (Boston Private Industry Council) as the first coded organization, 9 of its 13 rendered sub-keys.
build_manifest_app_files() listed only R/data.R, but that file is a loader that sources ten modules in R/data/ at boot, so regenerating the manifest would have produced a bundle that cannot start. Also adds interview_data.json.enc, interview_translations.json and service_details.json: all three degrade to rendering nothing when absent, so omitting them fails silently rather than loudly.
Adds main_ui.R, footer_ui.R, about_ui.R and the three optional runtime data files, including the new service_details.json; drops the three www/html entries no longer on disk. Platform left pinned at 4.5.2 rather than the local 4.6.0 so this does not silently change the R version Connect Cloud deploys under.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.