Feat/service details content - #54
Merged
Merged
Conversation
load_service_details() held one cached value for the whole process, so the path argument was ignored after the first call and whichever caller ran first fixed the value for everyone. The cache is now keyed by path: a different path reads fresh, the default path still memoises. Caught by the missing-file test, which had been passing only while the real file happened to be empty.
list_org_subcats.R prints the sub-keys an organization's wheel actually renders, derived from org_subcat_keys() rather than read off the spreadsheet, since the rendered set depends on label matching and established-state gating. merge_service_details.R combines one JSON file per organization into the single file the app reads, validating sub-keys against the taxonomy and rejecting unknown dimensions, over-long text, duplicate organizations and filename/id mismatches, refusing to write on any problem. It also normalises the fragment form a coding chat emits, plus markdown fences, trailing commas and BOMs.
One authored JSON file per organization under data/service_details/, merged into data/service_details.json by R/scripts/merge_service_details.R.
HaritMT25
force-pushed
the
feat/service-details-content
branch
from
August 18, 2026 03:42
5e0a683 to
58e93d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.