Feat/org about and copy - #56
Merged
Merged
Conversation
Three stakeholder-requested content changes, landed together because they overlap in the translation files and on the details page. About Org from the survey is now on the clean schema as about and renders in a public full-width card above the Age Breakdown, omitted rather than shown empty for the four orgs that left it blank. The established and emerging cards gain a collapsible What does this mean? definition, using a native details element so it needs no JavaScript. The About page Connect section and the Home login card now invite organizations to email the lab for corrections. Also fixes a latent encoding bug: read_qualtrics_export passed no encoding to read.csv, and About Org is the only column in the export carrying non-ASCII characters, so em dashes and curly quotes in six organizations would have reached production mangled. detect_export_encoding now selects UTF-8, UTF-8-BOM, or Windows-1252 explicitly.
shiny.router navigates by hash, and a fragment like !/organizations/details matches no element id, so the browser preserved the scroll offset from the organizations list and clamped it to the bottom of the shorter detail page. Query-param updates use pushState and never fire hashchange, so filter and theme changes are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.