test: add iOS ShakeDevice and PerformTouchID coverage - #1129
Merged
Merged
Conversation
IOSDriver.ShakeDevice() and PerformTouchID(bool) had no test coverage. Add DeviceInteractionTest with a Touch ID enrollment step so the biometric match/no-match commands can actually execute on a simulator.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Adds iOS integration coverage for device shaking and Touch ID simulation.
Changes:
- Tests
IOSDriver.ShakeDevice(). - Enrolls biometrics and tests matching and non-matching Touch ID flows.
File summaries
| File | Description |
|---|---|
test/integration/IOS/DeviceInteractionTest.cs |
Adds iOS device interaction integration tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
KazuCocoa
approved these changes
Sep 18, 2026
KazuCocoa
left a comment
KazuCocoa
left a comment
Member
There was a problem hiding this comment.
Did it work? I mean not the response wise, but actually if shake worked
Collaborator
Author
|
Checked — typed text into a field, called |
Collaborator
Author
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title
test: add iOS ShakeDevice and PerformTouchID coverage
Related issue
Closes # n/a
List of changes
test/integration/IOS/DeviceInteractionTest.cscoveringIOSDriver.ShakeDevice()andIOSDriver.PerformTouchID(bool), neither of which had any existing test coverage.PerformTouchIdTestfirst enrolls Touch ID on the simulator viamobile: enrollBiometric(required beforesendBiometricMatchhas anything to match against), then exercises both the match and no-match paths.Types of changes
Tests
How they run: Picked up by the existing
FullyQualifiedName~IOSCI filter (tagged[Category("iOS")]), no CI changes needed.Documentation
Details
Verified locally against a real booted iOS 26.0 "iPhone 17" simulator with a local Appium server + XCUITest driver: both tests pass. Note for anyone running this locally without CI's
LOCAL_PREBUILT_WDAenv var set — a cold WebDriverAgent build can take long enough that the client-side HTTP request drops before the server responds (looks like a connection failure, isn't). Grab a prebuilt WDA first:appium driver run xcuitest download-wda-sim --platform=ios --outdir=<dir>and setLOCAL_PREBUILT_WDAto the extracted.apppath.