ci: create env.json before build in functional tests - #1130
Merged
Merged
Conversation
MSBuild's Condition="Exists('env.json')" for the CopyToOutputDirectory
item is evaluated during dotnet build, so creating env.json after the
build step (and running tests with --no-build) meant it never made it
into bin/Release/net8.0, failing test setup with a missing file error.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Moves env.json creation before restore/build in Android and iOS functional-test jobs.
Changes:
- Reorders environment-file creation before restore/build.
- Applies the fix to both functional-test jobs.
File summaries
| File | Description |
|---|---|
.github/workflows/functional-test.yml |
Reorders CI steps in both functional-test jobs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
KazuCocoa
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title
ci:— no new label required.Related issue
Closes # n/a
List of changes
.github/workflows/functional-test.yml, move the "Create test environment file" step before "Build solution" in both theandroid-testsandios-testsjobs.Types of changes
Tests
How they run: This is a CI workflow ordering fix; it's exercised by the existing
functional-test.ymlruns themselves (Android/iOS jobs) rather than by unit/integration tests.Documentation
Details
The
android-testsandios-testsjobs infunctional-test.ymlrandotnet buildbefore the "Create test environment file" step wrotetest/integration/env.json. The integration test csproj has:Condition="Exists('env.json')"is evaluated at build time, so whenenv.jsondoesn't exist yet duringdotnet build, the item is excluded from the project and never copied tobin/Release/net8.0. Since the test step then runs with--no-build, the file is never copied later either, producing:Fix: create
env.jsonbeforedotnet buildruns so it exists when the project is evaluated and gets copied to the output directory as intended.Reference failing run: https://github.com/Dor-bl/dotnet-client/actions/runs/35195002624/job/105116041898#step:15:91