Fix Sliding Window Logic and Add Error Handling in Inference Scripts - #1
Open
stephen-netu wants to merge 2 commits into
Open
Fix Sliding Window Logic and Add Error Handling in Inference Scripts#1stephen-netu wants to merge 2 commits into
stephen-netu wants to merge 2 commits into
Conversation
…hensive error handling for network requests, file loading, and model loading, and improve code documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
This pull request addresses a critical bug in the sliding window implementation that prevented proper image coverage for non-square inputs, and adds comprehensive error handling to improve script reliability and user experience.
Key Changes
1. Sliding Window Bug Fix (reward_model_example_inference.py)
2. Error Handling Improvements
generator_model_client_inference.py:
reward_model_example_inference.py:
3. Code Quality Enhancements
Testing Performed
Files Modified